Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pprof HTTP server for snapshotter #372

Merged
merged 7 commits into from
Feb 23, 2023

Conversation

sctb512
Copy link
Member

@sctb512 sctb512 commented Feb 22, 2023

As titled. This PR is addressing #359

image

To visualise:

go tool pprof -http :LOCAL_PORT http://HOST:PORT/debug/pprof/goroutine

Signed-off-by: Bin Tang <tangbin.bin@bytedance.com>
Signed-off-by: Bin Tang <tangbin.bin@bytedance.com>
Signed-off-by: Bin Tang <tangbin.bin@bytedance.com>
Signed-off-by: Bin Tang <tangbin.bin@bytedance.com>
Signed-off-by: Bin Tang <tangbin.bin@bytedance.com>
Signed-off-by: Bin Tang <tangbin.bin@bytedance.com>
Signed-off-by: Bin Tang <tangbin.bin@bytedance.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2023

Codecov Report

Base: 29.26% // Head: 29.22% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (335b169) compared to base (302c0c3).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #372      +/-   ##
==========================================
- Coverage   29.26%   29.22%   -0.04%     
==========================================
  Files          38       38              
  Lines        3810     3815       +5     
==========================================
  Hits         1115     1115              
- Misses       2563     2568       +5     
  Partials      132      132              
Impacted Files Coverage Δ
config/config.go 19.29% <ø> (ø)
config/default.go 0.00% <ø> (ø)
config/global.go 32.14% <0.00%> (-1.20%) ⬇️
pkg/daemon/daemon.go 0.00% <0.00%> (ø)
pkg/manager/daemon_adaptor.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@changweige changweige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@imeoer imeoer merged commit 9350a97 into containerd:main Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants