Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable/v0.7] converter: fix image history handle #429

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

imeoer
Copy link
Collaborator

@imeoer imeoer commented Mar 21, 2023

  1. If the original image is already an OCI type, we should forcibly set the bootstrap layer to the OCI type.
  2. We need to append history item for bootstrap layer, to ensure the history consistency, see: https://github.com/distribution/distribution/blob/e5d5810851d1f17a5070e9b6f940d8af98ea3c29/manifest/schema1/config_builder.go#L136

1. If the original image is already an OCI type, we should forcibly set the
   bootstrap layer to the OCI type.
2. We need to append history item for bootstrap layer, to ensure the history
   consistency, see:
   https://github.com/distribution/distribution/blob/e5d5810851d1f17a5070e9b6f940d8af98ea3c29/manifest/schema1/config_builder.go#L136

Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
@changweige changweige merged commit 2abb493 into containerd:stable/v0.7 Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants