Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sign-compares and lz4 include #291

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Conversation

liulanzheng
Copy link
Member

What this PR does / why we need it:

  • fix sign-compare errors affected by ocf's CMake configuration
  • remove lz4 include in compressor.h

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Signed-off-by: liulanzheng <lanzheng.liulz@alibaba-inc.com>
Copy link
Contributor

@yuchen0cc yuchen0cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuchen0cc yuchen0cc merged commit 0ff47ea into containerd:main Nov 17, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants