Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on Arch Linux #315

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Fix build on Arch Linux #315

merged 1 commit into from
Feb 26, 2024

Conversation

benwaffle
Copy link
Contributor

What this PR does / why we need it: Fixes a compilation error I get when building on Arch Linux. The numeric types (e.g. uint64_t) are defined in <cstdint> and the header file needs to be included.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

@liulanzheng
Copy link
Member

@benwaffle Thank you. Could you mind to use git commit -s --amend --no-edit to sign your name and repush it?

Signed-off-by: Ben Iofel <bi@fly.io>
@benwaffle
Copy link
Contributor Author

@liulanzheng done

Copy link
Member

@liulanzheng liulanzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liulanzheng liulanzheng merged commit bcb8f21 into containerd:main Feb 26, 2024
2 checks passed
@benwaffle benwaffle deleted the fix-build branch February 27, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants