Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
The latest version of protoc-gen-go doesn't support gRPC. Supporting multiple generators is the way to support gRPC going forward. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
- Loading branch information
Showing
5 changed files
with
183 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| /* | ||
| Copyright The containerd Authors. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package main | ||
|
|
||
| import "testing" | ||
|
|
||
| func TestReadConfigFrom(t *testing.T) { | ||
| testcases := []struct { | ||
| name string | ||
| toml string | ||
| }{ | ||
| { | ||
| name: "empty", | ||
| toml: `version="unstable"`, | ||
| }, | ||
| { | ||
| name: "generator", | ||
| toml: ` | ||
| version="unstable" | ||
| generator="go" | ||
| `, | ||
| }, | ||
| { | ||
| name: "generators", | ||
| toml: ` | ||
| version="unstable" | ||
| generators=["go"] | ||
| `, | ||
| }, | ||
| } | ||
|
|
||
| for _, tc := range testcases { | ||
| t.Run(tc.name, func(t *testing.T) { | ||
| c, err := readConfigFrom([]byte(tc.toml)) | ||
| if err != nil { | ||
| t.Fatalf("err must be nil, but got %v", err) | ||
| } | ||
| if c.Generator == "go" { | ||
| t.Fatalf("Generator must be cleared, but got %v", c.Generator) | ||
| } | ||
| if len(c.Generators) != 1 || c.Generators[0] != "go" { | ||
| t.Fatalf("Generators must be [go], but got %v", c.Generators) | ||
| } | ||
| }) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| /* | ||
| Copyright The containerd Authors. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package main | ||
|
|
||
| import "testing" | ||
|
|
||
| func TestMkcmd(t *testing.T) { | ||
| testcases := []struct { | ||
| name string | ||
| cmd protocCmd | ||
| expected string | ||
| }{ | ||
| { | ||
| name: "basic", | ||
| cmd: protocCmd{Names: []string{"go"}}, | ||
| expected: "protoc -I --go_out=import_path=:", | ||
| }, | ||
| { | ||
| name: "plugin", | ||
| cmd: protocCmd{Names: []string{"go"}, Plugins: []string{"grpc"}}, | ||
| expected: "protoc -I --go_out=plugins=grpc,import_path=:", | ||
| }, | ||
| { | ||
| name: "use protoc-gen-go-grpc instead of plugins", | ||
| cmd: protocCmd{Names: []string{"go", "go-grpc"}}, | ||
| expected: "protoc -I --go_out=import_path= --go-grpc_out=import_path=:", | ||
| }, | ||
| } | ||
| for _, tc := range testcases { | ||
| t.Run(tc.name, func(subtest *testing.T) { | ||
| cmd := &tc.cmd | ||
|
|
||
| s, err := cmd.mkcmd() | ||
| if err != nil { | ||
| subtest.Fatalf("err must be nil but %+v", err) | ||
| } | ||
|
|
||
| if s != tc.expected { | ||
| subtest.Fatalf(`s must be %q, but %q`, tc.expected, s) | ||
| } | ||
| }) | ||
| } | ||
| } |