Cleanup output when no previous version #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove dead link at bottom Don't keep dependency section empty when no dependencies, mention no dependencies but keep section header for consistency. Signed-off-by: Derek McGowan <derek@mcg.dev>
|
We should also do 1.0 of this project, it would help for that 😆 |
thaJeztah
reviewed
May 14, 2020
| * **{{$dep.Name}}** {{if $dep.Previous}}{{$dep.Previous}} -> {{$dep.Ref}}{{else}}{{$dep.Ref}} **_new_**{{end}} | ||
| {{- end}} | ||
| {{- else}} | ||
| This release has no dependency changes |
There was a problem hiding this comment.
Should we omit the whole "dependency changes" section if there's no previous deps?
There was a problem hiding this comment.
I was thinking that, but since it is a top level header, I feel like it is better to say it explicitly. Otherwise you might scroll to the bottom looking for it and wonder if you missed it or was excluded
There was a problem hiding this comment.
To me, no dependency changes is a good feature too ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove dead link at bottom when no previous version.
Don't keep dependency section empty when no dependencies, mention no dependencies but keep section header for consistency.
This will help use this tool for projects reaching 1.0