Skip to content

Commit

Permalink
feat(*): remove the network ns in the shim start
Browse files Browse the repository at this point in the history
this commit removes the unnecessary nerwork namepsace setup in the
shim start function because it is already been set in youki

Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
  • Loading branch information
Mossaka committed Mar 5, 2024
1 parent 304bcfe commit eabc519
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions crates/containerd-shim-wasm/src/sandbox/shim/cli.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ use shim::Flags;
use crate::sandbox::instance::Instance;
use crate::sandbox::shim::events::{RemoteEventSender, ToTimestamp};
use crate::sandbox::shim::local::Local;
use crate::sys::networking::setup_namespaces;

/// Cli implements the containerd-shim cli interface using `Local<T>` as the task service.
pub struct Cli<T: Instance + Sync + Send> {
Expand Down Expand Up @@ -53,9 +52,6 @@ where
.and_then(|a| a.get("io.kubernetes.cri.sandbox-id"))
.unwrap_or(&id);

setup_namespaces(&spec)
.map_err(|e| shim::Error::Other(format!("failed to setup namespaces: {}", e)))?;

let (_child, address) = shim::spawn(opts, grouping, vec![])?;

write_address(&address)?;
Expand Down

0 comments on commit eabc519

Please sign in to comment.