cgroup: v2: do not set subtree_control for new cg #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hit another issue I thought was due to some other changes I have in my working tree, guess it's not just that... |
cpuguy83
force-pushed
the
cg2_ebusy
branch
2 times, most recently
from
f777fa4
to
c51cb4a
Compare
|
Ok this is good to go. |
|
/cc @jsturtevant |
A cgroup can either have delegations (`cgroup.subtree_control` is populated) OR it can have processes in it, but not both. So we need to make sure that we don't add any controllers to the new cgroup's `cgroup.subtree_control` BUT we should continue to do so for any parents that we create. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
|
Fixed comments |
jsturtevant
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A cgroup can either have delegations (
cgroup.subtree_controlis populated) OR it can have processes in it, but not both. So we need to make sure that we don't add any controllers to the new cgroup'scgroup.subtree_controlBUT we should continue to do so for any parents that we create.Fixes #35