Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove temporary work around and bump containerd versions #181

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

jsturtevant
Copy link
Contributor

Containerd 1.7.4 has the fix for the dependency issue fixed previously in #179

@github-actions github-actions bot added the T-CI Changes in project's CI label Aug 24, 2023
@jsturtevant
Copy link
Contributor Author

hmm doesn't seem to like containerd 1.7.4 😬

Copy link
Member

@Burning1020 Burning1020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsturtevant
Copy link
Contributor Author

I guess something might have been wrong with 1.7.4, 1.7.5 was released last night so updated to that version

@jsturtevant
Copy link
Contributor Author

After rebasing and upgrading to the latest versions, things seems more stable, had a green pass and now only a couple tests failed, will run it a few more times.

failed test is run:

2023-09-26T20:27:12.7165195Z     container_linux_test.go:721: write /proc/self/fd/15: broken pipe
2023-09-26T20:27:12.7176473Z     container_linux_test.go:729: write /proc/self/fd/15: broken pipe
2023-09-26T20:27:12.7266379Z     container_linux_test.go:751: expected output "hello\nhello\n" but received ""
FAIL: TestContainerAttachProcess (0.18s)
2023-09-26T20:27:13.5154455Z     container_linux_test.go:520: write /proc/self/fd/15: broken pipe
2023-09-26T20:27:13.5171721Z     container_linux_test.go:533: write /proc/self/fd/15: broken pipe
2023-09-26T20:27:13.5676024Z     container_linux_test.go:554: expected output "hello\nhello\n" but received ""
FAIL: TestContainerAttach (0.15s)

@jsturtevant
Copy link
Contributor Author

another successful run

@jsturtevant
Copy link
Contributor Author

another successful run

Signed-off-by: James Sturtevant <jstur@microsoft.com>
@jsturtevant
Copy link
Contributor Author

another successful pass

@mxpv mxpv merged commit 1a18196 into containerd:main Sep 27, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-CI Changes in project's CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants