Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.7.0 of Shim and 0.5.0 of client #252

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

jsturtevant
Copy link
Contributor

There have been some dependency version increases, updates to the protobuf files and small improvements since last release.

In runwasi, we are blocked on an update since the containerd client wasn't on prost-types 12.x: containerd/runwasi#488

Signed-off-by: James Sturtevant <jstur@microsoft.com>
@github-actions github-actions bot added C-runc-shim Runc shim C-shim-protos Shim protos C-shim Containerd shim C-client Containerd client labels Mar 12, 2024
@jsturtevant jsturtevant requested a review from mxpv March 12, 2024 21:42
@mxpv mxpv added this pull request to the merge queue Mar 13, 2024
Merged via the queue into containerd:main with commit 798ab74 Mar 13, 2024
18 checks passed
@mxpv
Copy link
Member

mxpv commented Mar 13, 2024

Client and shim-protos releases are here.

Interestingly shim publish job has failed.

@mxpv
Copy link
Member

mxpv commented Mar 13, 2024

Hmm.. I can reproduce it locally. I wonder why wasn't it caught on CI:

$ cargo build -p containerd-shim                                                                                                                                                                                                                [took 10s] ✦    v1.71.1
   Compiling value-bag v1.7.0
  ...
   Compiling containerd-shim-protos v0.7.0 (/Users/mxpv/Github/rust-extensions/crates/shim-protos)
   Compiling containerd-shim v0.7.0 (/Users/mxpv/Github/rust-extensions/crates/shim)
error[E0308]: mismatched types
   --> crates/shim/src/synchronous/mod.rs:502:28
    |
502 |                 parent_fd: _listener.as_raw_fd(),
    |                            ^^^^^^^^^^^^^^^^^^^^^ expected `OwnedFd`, found `i32`

For more information about this error, try `rustc --explain E0308`.
error: could not compile `containerd-shim` (lib) due to previous error

@mxpv
Copy link
Member

mxpv commented Mar 14, 2024

The new shim release is here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-client Containerd client C-runc-shim Runc shim C-shim Containerd shim C-shim-protos Shim protos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants