-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] buildkit integration #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmarking ResultRuns on the ubuntu-18.04 runner on Github Actions. python:3.7
gcc:9.2.0
rethinkdb:2.3.6
glassfish:4.1-jdk8
|
Buildkit integration performance(without exporting)OCI WorkerWith original baseimage
With stargz baseimage
containerd Workerreal 0m3.044s With original baseimage
real 0m17.914s With stargz baseimage
real 0m2.976s Buildkit integration performance(with exporting:
|
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
Benchmarking ResultRuns on the ubuntu-18.04 runner on Github Actions. python:3.7
gcc:9.2.0
rethinkdb:2.3.6
glassfish:4.1-jdk8
|
Buildkit integration performance(without exporting)OCI WorkerWith original baseimage
With stargz baseimage
containerd WorkerWith original baseimage
With stargz baseimage
Buildkit integration performance(with exporting:
|
Can you open a proposal for BuildKit changes in https://github.com/moby/buildkit/issues cc @tonistiigi |
Yes. Before that, please let me re-open this PR from my forked repo. |
Reopened on #53. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experimental integration with buildkit for speeding up fetching base image.
Our patched version of buildkit is here.
This commit includes benchmark scripts to measure the time for buliding sample images.
See this doc for manual testing.
Though it seems good for the lazy distribution of the base images, we currently have two problems for exporting output image.
tar
. It is because when we use remote snapshotters, containerd doesn't store the image contents in the content store but buildkit needs to use these contents for exporting images.