Define log message for failure of remote snapshot preparation #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
May 22, 2020
|
I agree with your comment. Though the change in the new commit is a bit larger than the initial scope in this PR, it formats the entire log with JSON. This is because this kind of use-cases (i.e. querying information from logs) might occur in the future again and we want to avoid the same issue so I thought it's good timing for moving to JSON. LMK what you think. |
ktock
force-pushed
the
check-sn
branch
2 times, most recently
from
1d04433
to
c8fc30a
Compare
AkihiroSuda
reviewed
May 23, 2020
snapshot/snapshot.go
Outdated
| // - "false" : indicates the snapshot failed to be prepared as a remote | ||
| // snapshot | ||
| // - null : undetermined | ||
| remoteSnapshot = "containerd.io/snapshot/prepare/remote.snapshot" |
There was a problem hiding this comment.
I thought to avoid name conflict because the key will be global but, yes I think so 🤔
Currently, we have two ways to check the success of remote snapshot preparation. Integration test checks output messages from `ctr-remote` command. CRI test checks the log from stargz daemon. We should unify them because we want to keep the consideration the about log messages as small as possible. We use the log from stargz daemon for both tests. This commit formats all log with JSON for ease of querying information and defines a special key for indicating whether remote snapshot preparation suceeded or not. This commit also adds this check to the benchmarking script. Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
AkihiroSuda
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we have two ways to check the success of remote snapshot
preparation. Integration test checks output messages from
ctr-remotecommand. CRI test checks the log from stargz daemon. We should unify them
because we want to keep the consideration the about log messages as small as
possible.
We use the log from stargz daemon for both tests. For preventing the message
from accidentally changed, this commit defines the message as
constvalue andadds some comments.
This commit also adds this check to the benchmarking script.