Allow some of prioritized files are missed during sort #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new option WithAllowPrioritizeNotFound. This makes Build continue the execution even if some of prioritized files specified by WithPrioritizedFiles option aren't found in the input tar. Instead, this records all missed file names to the passed slice. Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
|
@mattmoor WDYT? |
|
I see, so this would collect the missed files, so that the caller knows what files were missed? |
|
Yes. So caller can optimize the layer in best-effort and know which files are missed. This information seems needed for indicating some warnings on the caller's side according to google/go-containerregistry#879 (comment) ? |
|
Yeah I think that'll be perfect for aggregating across layers and images and surfacing back to the user what was missing. |
AkihiroSuda
approved these changes
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#212 (comment)
This commit adds a new option WithAllowPrioritizeNotFound. This makes Build
continue the execution even if some of prioritized files specified by
WithPrioritizedFiles option aren't found in the input tar. Instead, this records
all missed file names to the passed slice.