Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service prefix option to generator #116

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Conversation

dmcgowan
Copy link
Member

@dmcgowan dmcgowan commented May 5, 2022

Allows namespacing ttrpc services in the same package as grpc services

See also containerd/protobuild#54

@dmcgowan dmcgowan added this to New in Code Review May 13, 2022
Signed-off-by: Derek McGowan <derek@mcg.dev>
@dmcgowan dmcgowan force-pushed the service-prefix branch 2 times, most recently from 3e43807 to 91c68a5 Compare July 6, 2022 06:48
Signed-off-by: Derek McGowan <derek@mcg.dev>
@dmcgowan dmcgowan marked this pull request as ready for review July 6, 2022 07:06
@dmcgowan dmcgowan moved this from New to Ready For Review in Code Review Jul 6, 2022
@dmcgowan dmcgowan added this to the 1.7 milestone Jul 6, 2022
@kzys kzys merged commit 0ac5158 into containerd:main Aug 30, 2022
Code Review automation moved this from Ready For Review to Done Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants