Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix server shutdown logic #130

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Fix server shutdown logic #130

merged 1 commit into from
Mar 8, 2023

Conversation

austinvazquez
Copy link
Contributor

@austinvazquez austinvazquez commented Feb 24, 2023 •
edited
Loading

Fixes #129

Simplify close idle connections logic in server shutdown to be more
intuitive. Modify add connection logic to check if server has been
shutdown before adding any new connections. Modify test to make all
calls before server shutdown.

Signed-off-by: Austin Vazquez macedonv@amazon.com

@austinvazquez austinvazquez force-pushed the fix-server-shutdown branch 10 times, most recently from fc0e242 to 9925d37 Compare February 25, 2023 00:31
@austinvazquez
Copy link
Contributor Author

austinvazquez commented Feb 25, 2023 •
edited
Loading

@austinvazquez austinvazquez force-pushed the fix-server-shutdown branch 3 times, most recently from 6006966 to e5894c3 Compare February 25, 2023 00:59
@austinvazquez austinvazquez marked this pull request as ready for review February 25, 2023 01:08
@austinvazquez
Fix server shutdown logic
19445fd 
Simplify close idle connections logic in server shutdown to be more
intuitive. Modify add connection logic to check if server has been
shutdown before adding any new connections. Modify test to make all
calls before server shutdown.

Signed-off-by: Austin Vazquez <macedonv@amazon.com>
This was referenced Feb 27, 2023
Merged
Closed
@kzys
Copy link
Member

kzys commented Mar 7, 2023

@dmcgowan @cpuguy83 PTAL

@dmcgowan dmcgowan merged commit 7e006e7 into containerd:main Mar 8, 2023
@austinvazquez austinvazquez deleted the fix-server-shutdown branch March 8, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kzys kzys kzys approved these changes

@dmcgowan dmcgowan dmcgowan approved these changes

@cpuguy83 cpuguy83 cpuguy83 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TestServerShutdown is flaky on Windows
4 participants
@austinvazquez @kzys @dmcgowan @cpuguy83