Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.travis: don't call go get if there is go.mod #55

Merged
merged 1 commit into from Oct 24, 2019

Conversation

fuweid
Copy link
Member

@fuweid fuweid commented Oct 24, 2019

when enable go module, go get will update the required version. It is
not supported to run in CI.

More info: golang/go#27643.

Signed-off-by: Wei Fu fuweid89@gmail.com

@fuweid fuweid force-pushed the me-test-vendor-check branch 5 times, most recently from 20a05eb to 81f68f9 Compare October 24, 2019 08:29
@fuweid fuweid changed the title testing: vendor checker .travis: don't call go get if there is go.mod Oct 24, 2019
when enable go module, go get will update the required version. It is
not supported to run in CI.

More info: golang/go#27643.

Signed-off-by: Wei Fu <fuweid89@gmail.com>
@thaJeztah
Copy link
Member

@SamWhited ptal

@SamWhited
Copy link

This LGTM.

@crosbymichael
Copy link
Member

LGTM

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 5046735 into containerd:master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants