-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix 404 link #10
fix 404 link #10
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
=======================================
Coverage 63.15% 63.15%
=======================================
Files 1 1
Lines 76 76
=======================================
Hits 48 48
Misses 21 21
Partials 7 7 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; but needs signed commit before we can merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
DCO SigningEach commit in a pull requests must be signed with a valid DCO. First configure git for dco signing:
Check your git config:
Create a branch for your PR, make your changes, create your commit,
*** If you pushed your commit already, amend it with your signature then force push the amended commit:
|
Signed-off-by: xumc <hmilym@gmail.com>
Signed-off-by: xumc <hmilym@gmail.com>
git can be a bit tricky, we've all been there :-) |
fix protobuf.Any 404 link in readme.md.
fixes #7
Signed-off-by: xumc hmilym@gmail.com