Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 404 link #10

Closed
wants to merge 6 commits into from
Closed

fix 404 link #10

wants to merge 6 commits into from

Conversation

xumc
Copy link
Contributor

@xumc xumc commented Oct 14, 2018

fix protobuf.Any 404 link in readme.md.

fixes #7

Signed-off-by: xumc hmilym@gmail.com

@codecov-io
Copy link

codecov-io commented Oct 14, 2018

Codecov Report

Merging #10 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #10   +/-   ##
=======================================
  Coverage   63.15%   63.15%           
=======================================
  Files           1        1           
  Lines          76       76           
=======================================
  Hits           48       48           
  Misses         21       21           
  Partials        7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a93fcdb...5524d33. Read the comment docs.

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; but needs signed commit before we can merge

@estesp
Copy link
Member

estesp commented Oct 15, 2018

Sorry @xumc, I just realized the commit itself is not signed; can you please amend your commit with the Signed-off-by signature and force push the branch? I am adding the common checks in #11 but that is not merged yet.

Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikebrow
Copy link
Member

DCO Signing

Each commit in a pull requests must be signed with a valid DCO.

First configure git for dco signing:

$ git config --local user.name "Full name here"
$ git config --local user.email "email address here"

Check your git config:

$ git config -l
user.name=Mike Brown
user.email=brownwm@us.ibm.com

Create a branch for your PR, make your changes, create your commit,
sign the commit with a signature line using the -s option,
and push the commit to your new branch:

$ git commit -s -m "this commit fixes..."

*** If you pushed your commit already, amend it with your signature then force push the amended commit:

$ git commit -s --amend

@xumc xumc closed this Oct 16, 2018
@mikebrow
Copy link
Member

git can be a bit tricky, we've all been there :-)

@estesp estesp mentioned this pull request Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken link in Readme
4 participants