Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc.go and expand documentation #12

Merged
merged 1 commit into from
Feb 28, 2019
Merged

Add doc.go and expand documentation #12

merged 1 commit into from
Feb 28, 2019

Conversation

dperny
Copy link
Contributor

@dperny dperny commented Feb 27, 2019

Adds a doc.go file explaining how to use the typeurl library. Additionally, expands the godoc comment for MarshalAny to explain the marshaling rules.

Adds a doc.go file explaining how to use the typeurl library.
Additionally, expands the godoc comment for MarshalAny to explain the
marshaling rules.

Signed-off-by: Drew Erny <drew.erny@docker.com>
@codecov-io
Copy link

codecov-io commented Feb 27, 2019

Codecov Report

Merging #12 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #12   +/-   ##
=======================================
  Coverage   63.15%   63.15%           
=======================================
  Files           1        1           
  Lines          76       76           
=======================================
  Hits           48       48           
  Misses         21       21           
  Partials        7        7
Impacted Files Coverage Δ
types.go 63.15% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 461401d...8250b3b. Read the comment docs.

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael
Copy link
Member

LGTM

@crosbymichael crosbymichael merged commit 2a93cfd into containerd:master Feb 28, 2019
@dperny dperny deleted the add-docs branch February 28, 2019 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants