Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Action-based CI workflow #19

Merged
merged 1 commit into from
Mar 27, 2020

Conversation

estesp
Copy link
Member

@estesp estesp commented Mar 27, 2020

This GitHub Action-based CI workflow fully replaces our current Travis CI setup and contains all the same steps.

The only thing I haven't verified is the codecov step, and I did see that there may be a built-in codecov action in the marketplace.

Signed-off-by: Phil Estes estesp@linux.vnet.ibm.com

Copy link

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>
@estesp
Copy link
Member Author

estesp commented Mar 27, 2020

Thanks to containerd/project#46 getting merged, I took out the TRAVIS=yes and TRAVIS_COMMIT_RANGE hacks just now.

@codecov-io
Copy link

Codecov Report

Merging #19 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #19   +/-   ##
=======================================
  Coverage   64.10%   64.10%           
=======================================
  Files           1        1           
  Lines          78       78           
=======================================
  Hits           50       50           
  Misses         21       21           
  Partials        7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b45ef1f...8d2749d. Read the comment docs.

Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit 6eb0fcc into containerd:master Mar 27, 2020
@estesp estesp deleted the github-action-ci branch March 27, 2020 15:31
@estesp
Copy link
Member Author

estesp commented Mar 27, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants