Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gha: replace deprecated "set-env", "add-path", update setup-go@v2, update go to 1.15 #24

Merged
merged 4 commits into from Feb 8, 2021

Conversation

thaJeztah
Copy link
Member

See individual commits for details

https://github.com/actions/setup-go/tree/v2.1.3#v2

The V2 offers:

- Adds GOBIN to the PATH
- Proxy Support
- stable input
- Bug Fixes (including issues around version matching and semver)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-io
Copy link

Codecov Report

Merging #24 (7f06489) into master (cd3ce71) will decrease coverage by 4.89%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
- Coverage   67.39%   62.50%   -4.90%     
==========================================
  Files           1        1              
  Lines          92       80      -12     
==========================================
- Hits           62       50      -12     
  Misses         22       22              
  Partials        8        8              
Impacted Files Coverage Δ
types.go 62.50% <0.00%> (-4.90%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd3ce71...7f06489. Read the comment docs.

@thaJeztah
Copy link
Member Author

@estesp @mxpv ptal

@thaJeztah
Copy link
Member Author

Pushed a commit to update the badge in the README, which was still showing Travis status

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Copy link
Member

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit cddef51 into containerd:master Feb 8, 2021
@thaJeztah thaJeztah deleted the update_gha branch February 8, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants