Use google.golang.org/protobuf instead of github.com/gogo/protobuf #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As like other containerd packages, this commit switches from github.com/gogo/protobuf to google.golang.org/protobuf. See containerd/containerd#6564 for the detail. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #30 +/- ##
=======================================
Coverage 67.36% 67.36%
=======================================
Files 1 1
Lines 95 95
=======================================
Hits 64 64
Misses 23 23
Partials 8 8
Continue to review full report at Codecov.
|
mxpv
approved these changes
Mar 20, 2022
|
Needs rebase |
AkihiroSuda
reviewed
Mar 23, 2022
| @@ -2,4 +2,7 @@ module github.com/containerd/typeurl | |||
|
|
|||
| go 1.13 | |||
There was a problem hiding this comment.
Maybe off-topic here, but this has to be bumped up to 1.17
|
Closing. We right now have both google.golang.org/protobuf and github.com/gogo/protobuf and it seems working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As like other containerd packages, this commit switches from
github.com/gogo/protobuf to google.golang.org/protobuf.
See containerd/containerd#6564 for the detail.
Signed-off-by: Kazuyoshi Kato katokazu@amazon.com