-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deps to get rid of k8s.io/kubernetes #32
Update deps to get rid of k8s.io/kubernetes #32
Conversation
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
3e2aa52
to
5a63297
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
gotest.tools v2.2.0+incompatible h1:VsBPFP1AI068pPrMxtb/S8Zkgf9xEmTLJjfM+P5UIEo= | ||
gotest.tools v2.2.0+incompatible/go.mod h1:DsYFclhRJ6vuDpmuTbkuFWG+y2sxOXAzmJt81HFBacw= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we know where this old version is still used?
edit; ah; hcsshim, looks like it;
go mod graph | grep ' gotest.tools@v2'
github.com/Microsoft/hcsshim@v0.8.14 gotest.tools@v2.2.0+incompatible
google.golang.org/grpc v1.26.0/go.mod h1:qbnxyOmOxrQa7FizSgH+ReBfzJrCY1pSN7KXBS8abTk= | ||
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0= | ||
gopkg.in/check.v1 v1.0.0-20180628173108-788fd7840127/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0= | ||
gopkg.in/yaml.v2 v2.2.2/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably check where this one is still used
go mod graph | grep ' gopkg.in/yaml.v2@v2.2.2'
github.com/urfave/cli@v1.22.2 gopkg.in/yaml.v2@v2.2.2
github.com/stretchr/testify@v1.4.0 gopkg.in/yaml.v2@v2.2.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main containerd repo is still on urfave/cli@v1.22.2 so not sure this can be solved in this repo?
EDIT: Missed the fact that we actually do a replace
down to v1.22.1 in containerd due to some regression
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For urfave, I had a PR to fix it, but it's somewhat complex, and have to revisit that one
Dependencies here definitely doesn't look urgent, but whenever I see a go.sum
contain multiple (older) versions, I'm always curious "who is depending on this?"
Let's finish fixing up any vendoring changes in the GH actions PR (#34) since it is based on Go 1.16 |
containerd/containerd depends on this repo and the go.mod/sum ends up pulling in
k8s.io/kubernetes
transitively to many other projects that vendor containerd including hcsshim and kubernetes.Signed-off-by: Davanum Srinivas davanum@gmail.com