Feat: added console writer for local logging #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
guacamole
commented
Mar 26, 2022
guacamole
commented
- pretty and readable logging for local debugging
guacamole
force-pushed
the
pretty-logger
branch
from
8b736a9
to
2d88371
Compare
jay-dee7
reviewed
Mar 26, 2022
telemetry/consoleWriter.go
Outdated
| e.Errors = append(e.Errors, err) | ||
| } | ||
| } else { | ||
| _, err = buf.WriteString(color.RedString(" %d", res.Status)) |
There was a problem hiding this comment.
@guacamole can we do yellow for warn and red for error?
There was a problem hiding this comment.
also can we please move status up? like right after we calculate log level?
jay-dee7
reviewed
Mar 26, 2022
telemetry/consoleWriter.go
Outdated
| e.Errors = append(e.Errors, err) | ||
| } | ||
|
|
||
| _, err = buf.WriteString(req.Method + " ") |
There was a problem hiding this comment.
@guacamole print method field before host
guacamole
force-pushed
the
pretty-logger
branch
from
72373c0
to
c64ddec
Compare
jay-dee7
added
enhancement
jay-dee7
reviewed
Mar 26, 2022
| l.Output(consoleWriter) | ||
| return l | ||
| } | ||
| zerolog.SetGlobalLevel(zerolog.DebugLevel) | ||
| return l | ||
| } | ||
|
|
There was a problem hiding this comment.
@guacamole can we remove this ZerologMiddleware? we don't use it anymore
- this way the handlers don't have to ctx.Set the error key each time and thus removing a bunch of repeated codes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.