Fix: logging by adding new logger struct #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added new logger struct to contain zerologger and echo logger - In the earlier implementaion, the logger was being called in middleware which caused the log messages to return caller as middelware instead of the handler within - This PR fixes the issue by removing the middleware and calling logger inside each handler Signed-off-by: guacamole <gunjanwalecha@gmail.com>
- Added new logger struct to contain zerologger and echo logger - In the earlier implementaion, the logger was being called in middleware which caused the log messages to return caller as middelware instead of the handler within - This PR fixes the issue by removing the middleware and calling logger inside each handler Signed-off-by: guacamole <gunjanwalecha@gmail.com>
guacamole
force-pushed
the
fix-logging
branch
from
e1b3ba6
to
2958a49
Compare
Signed-off-by: jay-dee7 <jasdeepsingh.uppal@gmail.com>
…to fix-logging Signed-off-by: jay-dee7 <jasdeepsingh.uppal@gmail.com>
jay-dee7
force-pushed
the
fix-logging
branch
from
c621aaa
to
1e44ff8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: guacamole gunjanwalecha@gmail.com