Postgres implementation #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jay-dee7 <jasdeepsingh.uppal@gmail.com>
- added queries and apis for users table Signed-off-by: guacamole <gunjanwalecha@gmail.com>
Signed-off-by: guacamole <gunjanwalecha@gmail.com>
Signed-off-by: guacamole <gunjanwalecha@gmail.com>
Signed-off-by: jay-dee7 <jasdeepsingh.uppal@gmail.com>
- Added support for catalog api, content discovery apis Signed-off-by: guacamole <gunjanwalecha@gmail.com>
Signed-off-by: guacamole <gunjanwalecha@gmail.com>
guacamole
force-pushed
the
postgres-implementation
branch
4 times, most recently
from
08d28ee
to
638b591
Compare
Signed-off-by: guacamole <gunjanwalecha@gmail.com>
guacamole
force-pushed
the
postgres-implementation
branch
from
638b591
to
a864016
Compare
Signed-off-by: jay-dee7 <jasdeepsingh.uppal@gmail.com>
jay-dee7
force-pushed
the
postgres-implementation
branch
from
2d18670
to
84f64b3
Compare
Signed-off-by: guacamole <gunjanwalecha@gmail.com>
…nRegistry into postgres-implementation
guacamole
force-pushed
the
postgres-implementation
branch
3 times, most recently
from
f0619e4
to
9564459
Compare
Signed-off-by: guacamole <gunjanwalecha@gmail.com>
guacamole
force-pushed
the
postgres-implementation
branch
from
9564459
to
b3fb04a
Compare
jay-dee7
force-pushed
the
postgres-implementation
branch
3 times, most recently
from
87a6b43
to
54f5551
Compare
Signed-off-by: guacamole <gunjanwalecha@gmail.com> Signed-off-by: jay-dee7 <jasdeepsingh.uppal@gmail.com>
jay-dee7
force-pushed
the
postgres-implementation
branch
2 times, most recently
from
e1f6d00
to
fb6ad3b
Compare
jay-dee7
force-pushed
the
postgres-implementation
branch
9 times, most recently
from
83c8012
to
2315376
Compare
Signed-off-by: jay-dee7 <jasdeepsingh.uppal@gmail.com>
jay-dee7
force-pushed
the
postgres-implementation
branch
from
2315376
to
1d11ce1
Compare
Signed-off-by: jay-dee7 <jasdeepsingh.uppal@gmail.com>
…nRegistry into postgres-implementation
Signed-off-by: guacamole <gunjanwalecha@gmail.com>
jay-dee7
reviewed
Dec 19, 2021
jay-dee7
reviewed
Dec 19, 2021
| run: | | ||
| curl -L https://github.com/golang-migrate/migrate/releases/download/v4.15.1/migrate.linux-amd64.tar.gz | tar xvz | ||
| sudo mv migrate /usr/bin/migrate | ||
| sudo netstat -tulnp |
jay-dee7
reviewed
Dec 19, 2021
| run: | | ||
| curl -L https://github.com/golang-migrate/migrate/releases/download/v4.15.1/migrate.linux-amd64.tar.gz | tar xvz | ||
| sudo mv migrate /usr/bin/migrate | ||
| sudo netstat -tulnp |
jay-dee7
reviewed
Dec 19, 2021
| run: | | ||
| curl -L https://github.com/golang-migrate/migrate/releases/download/v4.15.1/migrate.linux-amd64.tar.gz | tar xvz | ||
| sudo mv migrate /usr/bin/migrate | ||
| sudo netstat -tulnp |
jay-dee7
reviewed
Dec 19, 2021
auth/signup.go
Outdated
| ctx.Set(types.HttpEndpointErrorKey, err.Error()) | ||
| return ctx.JSON(http.StatusInternalServerError, echo.Map{ | ||
| "error": err.Error(), | ||
| }) | ||
| } | ||
|
|
||
| // key := fmt.Sprintf("%s/%s", UserNameSpace, u.Username) |
There was a problem hiding this comment.
@guacamole lets remove these comments
jay-dee7
reviewed
Dec 19, 2021
auth/signup.go
Outdated
| if err := a.store.Set([]byte(key), bz); err != nil { | ||
| err = a.pgStore.AddUser(ctx.Request().Context(), newUser) | ||
|
|
||
| // bz, err = json.Marshal(u) |
jay-dee7
reviewed
Dec 19, 2021
auth/validate_user.go
Outdated
| @@ -13,17 +13,22 @@ func (a *auth) validateUser(username, password string) (map[string]interface{}, | |||
| return nil, fmt.Errorf("Email/Password cannot be empty") | |||
| } | |||
|
|
|||
| key := fmt.Sprintf("%s/%s", UserNameSpace, username) | |||
| bz, err := a.store.Get([]byte(key)) | |||
| //key := fmt.Sprintf("%s/%s", UserNameSpace, username) | |||
There was a problem hiding this comment.
@guacamole remove these comments too
jay-dee7
reviewed
Dec 19, 2021
| @@ -0,0 +1,48 @@ | |||
|
|
|||
There was a problem hiding this comment.
@guacamole do we want to keep this? since we're already using migrate to handle all of this, maybe we can remove it?
There was a problem hiding this comment.
let's keep it since this is our working schema
jay-dee7
reviewed
Dec 19, 2021
scripts/postgres/setup.sh
Outdated
| @@ -0,0 +1,7 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
@guacamole lets remove this since migrate cli is already handling this
jay-dee7
reviewed
Dec 19, 2021
types/types.go
Outdated
| Reference string | ||
| Digest string | ||
| } | ||
| //Manifest struct { |
jay-dee7
requested changes
Dec 19, 2021
There was a problem hiding this comment.
@guacamole other than some comment removal, this PR is good to go. We have quite some mess about badger and postgres and it's better if we track that via a different PR
Signed-off-by: guacamole <gunjanwalecha@gmail.com>
jay-dee7
approved these changes
Dec 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress: 58 conformance tests are passing