GitHub auth #95
Merged
GitHub auth #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
jay-dee7
force-pushed
the
github-auth
branch
5 times, most recently
from
dcf6845
to
dd16d89
Compare
jay-dee7
added
the
P1
Signed-off-by: jay-dee7 <jasdeepsingh.uppal@gmail.com>
Signed-off-by: jay-dee7 <jasdeepsingh.uppal@gmail.com>
guacamole
reviewed
Mar 28, 2022
guacamole
reviewed
Mar 28, 2022
Github CodeQL detected a medium level security vulerability in this run: https://github.com/containerish/OpenRegistry/runs/5711928771 In GithubCallbackHandler, we receive a "path" query param, which we use to redirect user back to our web interface. We anyway provide webui redirect url via config so it's better to stick to that. Signed-off-by: jay-dee7 <jasdeepsingh.uppal@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🔥 Login With Github Support
We can now let users login into OpenRegistry using Github.
Web login is working fine now but when we sign user up using Github (first time login), then it's impossible to login to docker cli. We've broken that functionality with this PR but it's being worked on using #99