Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONTRIBUTING documentation improvements #174

Closed
2 tasks
steveej opened this issue Apr 2, 2016 · 1 comment
Closed
2 tasks

CONTRIBUTING documentation improvements #174

steveej opened this issue Apr 2, 2016 · 1 comment
Assignees
@squaremo
Labels
kind/documentation kind/enhancement
Milestone
v1.0.0

Comments

@steveej
Copy link
Member

steveej commented Apr 2, 2016

We should cover these in the CONTRIBUTING docs

  • Tests
  • License header for source files
@steveej steveej modified the milestones: v0.2.0, v1.0.0 Apr 8, 2016
@squaremo squaremo self-assigned this May 19, 2016
@squaremo
Copy link
Member

Re tests, the doc mentions making sure they pass, and adding tests as necessary -- is there more you'd like to be said @steveej?

squaremo added a commit to squaremo/cni that referenced this issue May 19, 2016
@squaremo
docs: Mention license headers and doc contributions
bcc189e 
Closes containernetworking#174.
@squaremo squaremo mentioned this issue May 19, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@squaremo squaremo

Labels
kind/documentation kind/enhancement
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
2 participants
@squaremo @steveej