Change DNS to pointer in NetConf/Results #1035
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1061123
changed the title
s1061123
changed the title
squeed
reviewed
Oct 30, 2023
| @@ -92,7 +92,7 @@ type Result struct { | |||
| Interfaces []*Interface `json:"interfaces,omitempty"` | |||
| IPs []*IPConfig `json:"ips,omitempty"` | |||
| Routes []*types.Route `json:"routes,omitempty"` | |||
| DNS types.DNS `json:"dns,omitempty"` | |||
| DNS *types.DNS `json:"dns,omitempty"` | |||
There was a problem hiding this comment.
Unfortunately, we can't change the API here, since it would break upgrades :-(.
There was a problem hiding this comment.
OK, I will change the way to keep the structure type in another PRs. thank you for comment!
This commit changes DNS as pointer to remove empty DNS field in Result. This will simplify Result format. This also changes SPEC to mention all keys are optional, other than 'cniVerison'. Signed-off-by: Tomofumi Hayashi <tohayash@redhat.com>
s1061123
force-pushed
the
dns-pointer
branch
from
b2a893c
to
eb33180
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes DNS in NetConf/Results to pointer. This PR contains #1007 and DNS Result change commit.
Plugin repo needs change: containernetworking/plugins#964