Extract and improve test helpers #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we backfill tests, it is useful to extract a common package of test helpers.
This PR pulls some basic test harness code out of
loopbackandnspackage test suites and makes them available for other tests.Because the test helpers contain some non-trivial code (syscalls for
unshare,mount, etc), I've backfilled unit tests of the test helpers themselves. Those backfilled tests exposed a couple bugs inMakeNetworkNS, which I've fixed in the final commit.You can see the test failures in Travis on the second-to-last commit, and then the fix on the final commit.
Happy to squash those last two if you prefer.