pkg/utils: add utils_test #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mars1024
reviewed
Dec 26, 2019
pkg/utils/utils_test.go
Outdated
|
|
||
| for _, tt := range testData { | ||
| err := ValidateContainerID(tt.containerID) | ||
| if err != nil && !tt.err { |
There was a problem hiding this comment.
Could you help to use DeepEqual to squash these lines?
There was a problem hiding this comment.
They are different structure types, and it seems that it is not suitable to use DeepEqual. If they are changed to agree types and then compared, more code will be generated.
There was a problem hiding this comment.
There was a problem hiding this comment.
updated, thanks for your suggestions. PTAL
|
BTW, commits need to be squashed either. |
zhouhao3
force-pushed
the
add-utils-test
branch
2 times, most recently
from
35cc4d9
to
025e32f
Compare
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
|
/lgtm |
jellonek
approved these changes
Jan 8, 2020
dcbw
approved these changes
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add corresponding unit tests to the functions in util.go.
Signed-off-by: Zhou Hao zhouhao@cn.fujitsu.com