Move Windows tests to Travis #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Appveyor failing is expected since I removed its config file 😄 |
rosenhouse
reviewed
Dec 12, 2018
| echo "Running tests" | ||
|
|
||
| PLUGINS=$(cat plugins/windows_only.txt | tr '\n' ' ') | ||
| GINKGO_FLAGS="-p -r --randomizeAllSpecs --randomizeSuites --failOnPending --progress pkg/hns $PLUGINS" |
There was a problem hiding this comment.
I'm not thrilled with this explicit pkg/hns but I'm also not ready to say we need a new abstraction here either. If we see other windows-only packages that aren't getting run in travis because of omission from this list, then we can revisit.
|
Yeah we can disable AppVeyor after this is merged. |
rosenhouse
approved these changes
Dec 12, 2018
squeed
approved these changes
Dec 19, 2018
|
Removed the appveyor hook too. |
|
Looks like there's some flakiness in Travis itself which is causing a failure on Windows/Go 1.10.x right now: https://travis-ci.community/t/go-command-not-found/340 https://travis-ci.org/containernetworking/plugins/builds/470107746 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I more or less tried combining the existing
.appveyor.ymland thetest.shscript. I removed line from the travis.yml installing gcc-multilib gcc-mingw-w64 since that won't work on Windows, and doesn't appear to be necessary on Linux either.I had to change
build_windows.shto create a temp directory for the GOPATH tricks that we do, since building a GOPATH in the current directory ends up with a path longer 255 characters which Windows doesn't like.Another semi-unfortunate thing is having to manually specify to test the
pkg/hnspackage. I couldn't think of another way, since other other packages in that directory don't build on Windows.