Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flannel: Pass through runtimeConfig to delegate #309

Merged
merged 1 commit into from May 8, 2019

Conversation

Projects
None yet
3 participants
@nagiesek
Copy link
Contributor

commented Apr 29, 2019

Currently we don't pass through the runtimeConfig from flannel down to the delegate call, I think it would be a good idea to do so.

@nagiesek

This comment has been minimized.

Copy link
Contributor Author

commented Apr 29, 2019

check for existence of runtimeConfig to fix test failure.

@benmoss

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

LGTM 👍

@dcbw

dcbw approved these changes May 1, 2019

Copy link
Member

left a comment

LGTM

@nagiesek nagiesek force-pushed the nagiesek:flannel branch from 2f8a6b1 to 071907f May 1, 2019

@dcbw dcbw merged commit 6bceb68 into containernetworking:master May 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.