Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #342, cleanup netns after test suite #375

Merged
merged 1 commit into from Aug 28, 2019

Conversation

smarkm
Copy link
Contributor

@smarkm smarkm commented Aug 21, 2019

Fixes #342, please also reference #373

Copy link
Member

@mars1024 mars1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dcbw
Copy link
Member

dcbw commented Aug 21, 2019

@smarkm looks good, but can you rebase onto containernetworking/plugins git master to get rid of the merge commit? Basically, you can add containernetworking/plugins as a git remote:

git remote add upstream git@github.com:containernetworking/plugins.git
git fetch upstream
git rebase upstream/master

and then push the PR again (you may need to git push -f to overwrite your existing PR branch, which is fine).

Thanks!

Signed-off-by: smarkm <smark@freecoop.net>
@smarkm
Copy link
Contributor Author

smarkm commented Aug 22, 2019

@dcbw thanks for your information!

Copy link
Member

@jellonek jellonek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dcbw dcbw changed the title Fixes #342, cleanup netns after test suit Fixes #342, cleanup netns after test suite Aug 28, 2019
@squeed
Copy link
Member

squeed commented Aug 28, 2019

awesome, thanks!

@squeed squeed merged commit f81a529 into containernetworking:master Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do we need clean up the the netns after test suit
5 participants