bridge: various fixes #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any way we can add test coverage for these changes? I've been thinking about refactoring this plugin, but its scarier to attempt when there are important features that might break while the tests remain green. |
|
Yeah, good point. Most of this should be testable. |
* Don't set the MAC, send gratuitous arp instead * Set the bridge's MAC to itself * Only disable DAD when necessary
|
@rosenhouse added a test for the "stable mac" case. Not sure how to reasonably test the other changes. |
|
@squeed looks like it went red |
|
Once #56 is merged we should see fewer test failures. A lot of these tests are dancing around with namespaces, making them non-deterministic. |
|
Yeah, I don't see how to add functional tests either. (all the more reason to refactor to a more dependency-injected style where we can have unit tests of the application-object). LGTM |
rosenhouse
approved these changes
Aug 30, 2017
This was referenced Jun 7, 2018
phoracek
pushed a commit
to phoracek/containernetworking-plugins
that referenced
this pull request
Mar 21, 2023
…istency-openshift-4.11-ose-containernetworking-plugins Updating ose-containernetworking-plugins images to be consistent with ART
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #60 #59 #52