bridge, spoof check: remove drop rule index #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failed lint error is fixed by #871 ; we should merge it asap. Let me know if I should rebase it. |
|
/retest |
maiqueb
force-pushed
the
mac-spoof-remove-index-when-adding-rules
branch
2 times, most recently
from
9525b91
to
f117c7c
Compare
Rules are appendend by default, thus using an index is redundant. Using an index also requires the full NFT cache, which causes a CNI ADD to be extremely slow. Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
maiqueb
force-pushed
the
mac-spoof-remove-index-when-adding-rules
branch
from
f117c7c
to
cac8230
Compare
|
/lgtm |
squeed
approved these changes
Apr 17, 2023
squeed
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rules are appendend by default, thus using an index is redundant. Using an index also requires the full NFT cache, which causes a CNI ADD to be extremely slow where there are a lot of chains (~ 10K).
This doesn't improve the CNI ADD times when there are a lot of tables though ...
Addresses BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2173485