Update linux plugins in doc #925
Conversation
astraw99
force-pushed
the
patch-1
branch
2 times, most recently
from
5da3a04
to
76f6932
Compare
astraw99
changed the title
tap and sbr plugins in doc
plugins/linux_only.txt
Outdated
| @@ -1,14 +1,18 @@ | |||
| plugins/ipam/dhcp | |||
| plugins/ipam/host-local | |||
There was a problem hiding this comment.
I think these plugins work on windows, so they should not be in this list.
There was a problem hiding this comment.
But there are plugins like plugins/ipam/host-local work both on linux and windows.
What about changing the file name from linux_only.txt to linux.txt, and windows_only.txt to windows.txt?
Then add the plugins into the list accordingly, it will be more clarify.
There was a problem hiding this comment.
if you'd like, feel free. But right now this PR is removing test coverage it shouldn't.
There was a problem hiding this comment.
Updated with filename changed.
PTAL thanks.
plugins/linux.txt
Outdated
There was a problem hiding this comment.
where is this file used? If it is just for documentation purposes, wouldn't it be better to say all except the windows folder?
There was a problem hiding this comment.
Yes, currently the linux.txt file is just for doc purposes.
Updated, PTAL thanks.
There was a problem hiding this comment.
but now you are removing host-local from windows which is not ok
There was a problem hiding this comment.
As host-local is both working in linux and windows, changed the filename from linux_only.txt to linux.txt, and windows_only.txt to windows.txt.
PTAL thanks.
Signed-off-by: astraw99 <wangchengiscool@gmail.com>
To make the doc better.