Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site/domain feature in preferences #113

Closed
situplastik opened this issue Jan 11, 2021 · 4 comments · Fixed by #114
Closed

Site/domain feature in preferences #113

situplastik opened this issue Jan 11, 2021 · 4 comments · Fixed by #114
Labels
enhancement New feature or request

Comments

@situplastik
Copy link
Contributor

Even if you don't want to tracked by google, sometimes need to use your google account (by oAuth) to log in in some website. I'm developing a website for a client that want to admit that option. Basically, configure the addons in order to admit connections from service.mywebsite.com

Looking on preferences, there is a whitelist textarea but is for google sites.

Captura de Pantalla 2021-01-11 a les 12 22 23

It would be great if there will be another textarea in order to put domain/subdomain allowed to be openned with Google Container. Or at least accept comunication by POST or GET.

Thanks for the addons, it works perfecty ;)

@situplastik situplastik changed the title Site/domain whitelist feature Site/domain feature Jan 11, 2021
@situplastik situplastik changed the title Site/domain feature Site/domain feature in preferences Jan 11, 2021
@hackerncoder
Copy link
Collaborator

Maybe we need to #112 and get a similar toolbar icon with features, such as the one requested here, and in #90.

@situplastik
Copy link
Contributor Author

@hackerncoder it would be interesting to update the plugin, for sure. I haven't got plenty of time to do it; anyone have it? As alternative, I've just made a PR in order to solve the problem until the core update arrive :)

Hope @Perflyst like it.

@hackerncoder
Copy link
Collaborator

hackerncoder commented Jan 11, 2021

I just have to find time to update it. This way of doing it is bad, from a usability standpoint. Your code is great, you redid some code to use it for both, but not everything can or does get reused in the same way.

@hackerncoder hackerncoder added the enhancement New feature or request label Jan 11, 2021
@situplastik
Copy link
Contributor Author

@hackerncoder totally agree with your comment, my contribution is not as reused as could be, but it solve a particular problem. I didn't know that a core update was planned in short/medium time, I saw that you ask for and no-one hands up...

Maybe, a well working route would be release a version with that feature in order to close many issues. When the core update will be done, we can waste or change the code I created :) (as you said that the feature is already)

@hackerncoder hackerncoder linked a pull request Jan 12, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

2 participants