New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: add allowlist on preferences #114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have suggested some changes, once those are done we can move on to testing.
I guest the to suggestion are resolved with the 2 commits. Thanks for the quick response @hackerncoder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small (take note Perflyst) scale testing shows that it works. If (for some reason (user stupidity)) a URL is in both allowlist and whitelist, whitelist will triumph (it gets checked after allowlist).
The text could probably be written better, Allowlist isn't something that a user would understand, like whitelist. But otherwise I'll accept it.
Thanks. I do not know if I currently have time for this project, if I do not come to test you can also merge if everything is fine. |
I fix a orthography error :) |
Inputting an invalid domain will clear the list, this is not good UX. |
Yes, it work as whitelisted field so the bugs are shared. Give me some days to try to solve both fields error :) |
There have been no changes. Do you have something? If not I will merge. |
Yes, sorry for the delay. I change Please merge and release a new version ASAP in order to close many issues :) Thanks for all. |
Pinging @Perflyst to create a new version. |
Thanks for your hard work @situplastik @hackerncoder ❤️ https://github.com/containers-everywhere/contain-google/releases/tag/1.5.4 |
A PR in order to solve several issues like #113 #111 #84 #79 :)
If you put some domain on the new field a Google Container is opened automatically. Tested in local and it works like a charm.