Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: add allowlist on preferences #114

Merged
merged 9 commits into from Mar 3, 2021
Merged

Chore: add allowlist on preferences #114

merged 9 commits into from Mar 3, 2021

Conversation

situplastik
Copy link
Contributor

A PR in order to solve several issues like #113 #111 #84 #79 :)

If you put some domain on the new field a Google Container is opened automatically. Tested in local and it works like a charm.

Copy link
Collaborator

@hackerncoder hackerncoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have suggested some changes, once those are done we can move on to testing.

background.js Outdated Show resolved Hide resolved
options.js Outdated Show resolved Hide resolved
@situplastik
Copy link
Contributor Author

I guest the to suggestion are resolved with the 2 commits. Thanks for the quick response @hackerncoder

@hackerncoder hackerncoder self-requested a review January 11, 2021 13:48
Copy link
Collaborator

@hackerncoder hackerncoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small (take note Perflyst) scale testing shows that it works. If (for some reason (user stupidity)) a URL is in both allowlist and whitelist, whitelist will triumph (it gets checked after allowlist).

The text could probably be written better, Allowlist isn't something that a user would understand, like whitelist. But otherwise I'll accept it.

@Perflyst
Copy link
Collaborator

Thanks. I do not know if I currently have time for this project, if I do not come to test you can also merge if everything is fine.

@hackerncoder hackerncoder linked an issue Jan 12, 2021 that may be closed by this pull request
@situplastik
Copy link
Contributor Author

I fix a orthography error :)

options.html Outdated Show resolved Hide resolved
options.js Outdated Show resolved Hide resolved
@hackerncoder hackerncoder added enhancement New feature or request needs-testing This PR needs to be tested to see if it works. Users please try and break it labels Feb 3, 2021
@hackerncoder
Copy link
Collaborator

Inputting an invalid domain will clear the list, this is not good UX.

@situplastik
Copy link
Contributor Author

Inputting an invalid domain will clear the list, this is not good UX.

Yes, it work as whitelisted field so the bugs are shared. Give me some days to try to solve both fields error :)

@hackerncoder
Copy link
Collaborator

There have been no changes. Do you have something? If not I will merge.

@situplastik
Copy link
Contributor Author

Yes, sorry for the delay. I change return []; to continue; of the validation function. That removing only the domain/s not valid according the domain_regex.

Please merge and release a new version ASAP in order to close many issues :) Thanks for all.

@situplastik
Copy link
Contributor Author

situplastik commented Mar 3, 2021

Searching on the Issues list in a fas way, I found many issues that talks about the same: #111 #84 #79 #76

@hackerncoder if you vinculate the PR all of them will be closed as #113 ;)

@hackerncoder hackerncoder merged commit 5fb66dd into containers-everywhere:master Mar 3, 2021
@hackerncoder
Copy link
Collaborator

Pinging @Perflyst to create a new version.

@Perflyst
Copy link
Collaborator

Perflyst commented Mar 3, 2021

Thanks for your hard work @situplastik @hackerncoder ❤️

https://github.com/containers-everywhere/contain-google/releases/tag/1.5.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-testing This PR needs to be tested to see if it works. Users please try and break it
Development

Successfully merging this pull request may close these issues.

Site/domain feature in preferences
3 participants