Merge pull request #51 from jmtd/test-change-processor

test change processor handling of ints

cct/module.py

@@ -163,7 +163,7 @@ def _get_resource_path(self, module, resource):
     def _process_environment(self, operation):
         if '$' in operation.command:
             operation.command = self._replace_variables(operation.command)
-        for i in xrange(len(operation.args)):
+        for i in range(len(operation.args)):
             if '$' in operation.args[i]:
                 operation.args[i] = self._replace_variables(operation.args[i])
 

tests/modules/dummy/dummy.py

@@ -0,0 +1,23 @@
+"""
+Copyright (c) 2015 Red Hat, Inc
+All rights reserved.
+
+This software may be modified and distributed under the terms
+of the MIT license. See the LICENSE file for details.
+"""
+
+import logging
+
+from cct.module import Module
+
+logger = logging.getLogger('cct')
+
+class Dummy(Module):
+    def dump(self, *args):
+        """
+        Dumps arguments to a logfile.
+
+        Args:
+         *args: Will be dumped :).
+        """
+        logger.info("dummy module performed dump with args %s and environment: %s" % (args, self.environment ))

tests/test_change_processor.py

@@ -0,0 +1,43 @@
+"""
+Copyright (c) 2015 Red Hat, Inc
+All rights reserved.
+
+This software may be modified and distributed under the terms
+of the MIT license. See the LICENSE file for details.
+"""
+
+import os
+import unittest
+import mock
+
+from cct.change_processor import ChangeProcessor
+
+class TestModule(unittest.TestCase):
+    def setUp(self):
+        os.environ['CCT_MODULES_PATH'] = 'tests/modules'
+
+    def test_process_string_values(self):
+        """
+        Make sure that changes that have string values are accepted
+        """
+        config = [{
+            'changes': [{'dummy.Dummy': [{'dump': '493'}]}],
+            'name': 'dummy'
+        }]
+        changerunner = ChangeProcessor(config)
+        changerunner.process()
+
+
+    def test_process_int_values(self):
+        """
+        Make sure that changes that have integer values are accepted
+        """
+        config = [{
+            'changes': [{'dummy.Dummy': [{'dump': 493}]}],
+            'name': 'dummy'
+        }]
+        changerunner = ChangeProcessor(config)
+        changerunner.process()
+
+if __name__ == '__main__':
+    unittest.main()