Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the slirp related flake in integration tests #110

Closed
baude opened this issue Mar 23, 2022 · 0 comments · Fixed by #113
Closed

fix the slirp related flake in integration tests #110

baude opened this issue Mar 23, 2022 · 0 comments · Fixed by #113

Comments

@baude
Copy link
Member

baude commented Mar 23, 2022

title says it all. we need to fix the flake.
Luap99 added a commit to Luap99/aardvark-dns that referenced this issue Mar 31, 2022
@Luap99
tests: fix slirp flake v2
9c8cdbd 
Commit 4a45167 points at the correct error source however the fix
for it was not working. ls -l will alwys look differnt when called on
different paths. We only want to compare the actual link target. Fix
this by using readlink.

Fixes containers#110

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99 added a commit to Luap99/aardvark-dns that referenced this issue Mar 31, 2022
@Luap99
tests: fix slirp flake v2
2c07691 
Commit 4a45167 points at the correct error source however the fix
for it was not working. ls -l will always look different when called on
different paths. We only want to compare the actual link target. Fix
this by using readlink.

Fixes containers#110

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@Luap99 Luap99 mentioned this issue Mar 31, 2022
Merged
Luap99 added a commit to Luap99/aardvark-dns that referenced this issue Mar 31, 2022
@Luap99
tests: fix slirp flake v2
8fbb1a6 
Commit 4a45167 points at the correct error source however the fix
for it was not working. ls -l will always look different when called on
different paths. We only want to compare the actual link target. Fix
this by using readlink.

Fixes containers#110

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99 added a commit to Luap99/aardvark-dns that referenced this issue Jul 26, 2022
@Luap99
tests: fix slirp flake v2
d43af8e 
Commit 4a45167 points at the correct error source however the fix
for it was not working. ls -l will always look different when called on
different paths. We only want to compare the actual link target. Fix
this by using readlink.

Fixes containers#110

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests: fix slirp flake v2 Luap99/aardvark-dns
1 participant
@baude