Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing object detection recipe #236

Conversation

Gregory-Pereira
Copy link
Collaborator

@Gregory-Pereira Gregory-Pereira commented Apr 11, 2024

Changes:

  • abstract object detection ms to ms dir
  • renaming recipe build dir to app
  • adding output flag on python model downloader
  • adding fixing makefile for this recipe
  • coresponding docs updates

@Gregory-Pereira Gregory-Pereira force-pushed the refactor-object-deteciton-recipe branch 3 times, most recently from e6950d3 to 26ebe17 Compare April 11, 2024 05:09
@Gregory-Pereira Gregory-Pereira changed the title abstract object detection ms to ms dir Fixing object detection recipe Apr 11, 2024
@Gregory-Pereira
Copy link
Collaborator Author

weird error about processing a tarball breaks image builds in the model_servers job: https://github.com/containers/ai-lab-recipes/actions/runs/8641815682/job/23691946666?pr=236#step:5:265. What do you make of this @lmilbaum ?

.github/workflows/object_detection.yaml Outdated Show resolved Hide resolved
model_servers/object_detection_python/Makefile Outdated Show resolved Hide resolved
model_servers/object_detection_python/base/Containerfile Outdated Show resolved Hide resolved
model_servers/object_detection_python/requirements.txt Outdated Show resolved Hide resolved
model_servers/object_detection_python/requirements.txt Outdated Show resolved Hide resolved
model_servers/object_detection_python/tests/conftest.py Outdated Show resolved Hide resolved
@lmilbaum
Copy link
Collaborator

weird error about processing a tarball breaks image builds in the model_servers job: https://github.com/containers/ai-lab-recipes/actions/runs/8641815682/job/23691946666?pr=236#step:5:265. What do you make of this @lmilbaum ?

No space left of device.
There are two options: one is to reduce the container image size. The second is to use a larger github runner. The second option will require some efforts.

@Gregory-Pereira Gregory-Pereira force-pushed the refactor-object-deteciton-recipe branch 2 times, most recently from a3f169b to 9270981 Compare April 11, 2024 13:30
@Gregory-Pereira Gregory-Pereira force-pushed the refactor-object-deteciton-recipe branch 3 times, most recently from e22d181 to 7015d0b Compare April 13, 2024 04:59
@Gregory-Pereira Gregory-Pereira marked this pull request as draft April 13, 2024 05:00
@Gregory-Pereira Gregory-Pereira force-pushed the refactor-object-deteciton-recipe branch 10 times, most recently from 57b0087 to 87c3d80 Compare April 15, 2024 19:43
@Gregory-Pereira Gregory-Pereira force-pushed the refactor-object-deteciton-recipe branch 9 times, most recently from d863ee7 to bc6236f Compare April 15, 2024 23:24
Signed-off-by: greg pereira <grpereir@redhat.com>
@Gregory-Pereira Gregory-Pereira force-pushed the refactor-object-deteciton-recipe branch from bc6236f to 9ac44fd Compare April 28, 2024 02:33
@Gregory-Pereira
Copy link
Collaborator Author

This is in the process of being moved to #278

@rhatdan
Copy link
Member

rhatdan commented Apr 29, 2024

CLosing, since it is being moved.

@rhatdan rhatdan closed this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants