refactor instructlab training images to use make targets #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes: 1) add label and arch options to builds 2) extending workflow to intel-bootc, amd-bootc, and better workflow naming Signed-off-by: greg pereira <grpereir@redhat.com>
Gregory-Pereira
requested review from
MichaelClifford,
rhatdan,
sallyom,
lmilbaum and
cgwalters
as code owners
lmilbaum
requested changes
Apr 29, 2024
|
The FYI I have tested builds and each of these aside from the |
Gregory-Pereira
force-pushed
the
refactor-instructlab-workflow-using-make
branch
from
c20e6f0
to
814cad7
Compare
|
I have dropped the slack notifications pieces |
lmilbaum
requested changes
Apr 29, 2024
Gregory-Pereira
force-pushed
the
refactor-instructlab-workflow-using-make
branch
from
e9bcd41
to
cee46cc
Compare
Signed-off-by: greg pereira <grpereir@redhat.com>
Gregory-Pereira
force-pushed
the
refactor-instructlab-workflow-using-make
branch
from
cee46cc
to
2167fb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #364
changes:
intel-bootc,amd-bootc, and better workflow naming/cc @sallyom @rhatdan @lmilbaum