Add unittests for volume idempotency

Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
containers · Apr 1, 2023 · 796c560 · 796c560
1 parent d0d51ed
commit 796c560
Show file tree

Hide file tree

Showing 4 changed files with 415 additions and 43 deletions.
diff --git a/plugins/module_utils/podman/podman_container_lib.py b/plugins/module_utils/podman/podman_container_lib.py
@@ -1430,7 +1430,7 @@ def prep_volume_for_comp(all_ms):
                     f = prep_tmpfs_for_comp(cr_com[i + 1])
                     if f:
                         before.append(f)
-                elif v == '--volume':
+                elif v in ('--volume', '-v'):
                     f = prep_volume_for_comp(cr_com[i + 1])
                     if f:
                         before.append(f)

diff --git a/test-requirements.txt b/test-requirements.txt
@@ -2,3 +2,4 @@ ansible-core
 pytest
 pytest-forked
 pytest-xdist
+pytest-mock
diff --git a/tests/integration/targets/podman_container_idempotency/tasks/idem_volumes.yml b/tests/integration/targets/podman_container_idempotency/tasks/idem_volumes.yml
@@ -190,7 +190,7 @@
 
 - name: check test13
   assert:
-    that: test13 is not changed
+    that: test13 is changed
 
 - containers.podman.podman_container:
     executable: "{{ test_executable | default('podman') }}"