Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mac_address to podman_container fields #146

Closed
ericzolf opened this issue Nov 16, 2020 · 2 comments · Fixed by #148
Closed

Add mac_address to podman_container fields #146

ericzolf opened this issue Nov 16, 2020 · 2 comments · Fixed by #148
Labels
enhancement New feature or request

Comments

@ericzolf
Copy link
Contributor

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind feature

Description

podman_container module doesn't offer the mac-address as field.

Additional information you deem important (e.g. issue happens only occasionally):

Without mac-address, I can't get a stable IP address through DHCP.

I attached a patched version of the module, untested yet but the change is rather straight forward:

podman_container.py.txt
@sshnaidm sshnaidm added the enhancement New feature or request label Nov 17, 2020
@sshnaidm
Copy link
Member

@ericzolf thanks, why wouldn't you make PR from this file? Seems good to me.
You can leave "Allow edits from maintainers" selected and then any other can fix or change your patch if you don't have a time.

@ericzolf
Copy link
Contributor Author

ericzolf commented Nov 22, 2020 •
edited

I could but the difference between my version, based on the Galaxy version, and the current master version is quite huge (I guess due to "Move containers logic to module utils"). Let's see...

ericzolf added a commit to ericzolf/ansible-podman-collections that referenced this issue Nov 22, 2020
@ericzolf
Add mac_address field to podman_container module
fb589b2 
* extended description of podman_container
* add mac_address field and add_param function in podman_container_lib
* closes containers#146
@ericzolf ericzolf mentioned this issue Nov 22, 2020
Merged
sshnaidm pushed a commit to ericzolf/ansible-podman-collections that referenced this issue Nov 23, 2020
@ericzolf @sshnaidm
Add mac_address field to podman_container module
9957b9c 
* extended description of podman_container
* add mac_address field and add_param function in podman_container_lib
* closes containers#146
sshnaidm pushed a commit that referenced this issue Nov 23, 2020
@ericzolf @sshnaidm
Add mac_address field to podman_container module
29a4bfa 
* extended description of podman_container
* add mac_address field and add_param function in podman_container_lib
* closes #146
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add mac_address field to podman_container module ericzolf/ansible-podman-collections
2 participants
@ericzolf @sshnaidm