Add podman_login_info module #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshnaidm
reviewed
Oct 26, 2020
plugins/modules/podman_login_info.py
Outdated
| argument_spec=dict( | ||
| executable=dict(type='str', default='podman'), | ||
| authfile=dict(type='path'), | ||
| registry=dict(type='str') |
There was a problem hiding this comment.
I'd add registry as required argument because podman's "--get-login" expects for it. Although it doesn't fail when it's not specified, but also doesn't print registry, only username. I'm not sure only username without registry would be useful output for user.
There was a problem hiding this comment.
OK, makes sense! I'll look into it.
There was a problem hiding this comment.
cool, also please rebase on master when you submit, thanks
sshnaidm
added
the
hacktoberfest-accepted
clelange
force-pushed
the
podman_login_info
branch
from
a9f164d
to
d6851d5
Compare
clelange
force-pushed
the
podman_login_info
branch
from
d6851d5
to
5f8fe1c
Compare
|
Rebased and squashed into a single commit. Now the registry parameter is mandatory and I also added a test for it. |
sshnaidm
approved these changes
Oct 26, 2020
|
@clelange very cool, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a module to check if one is logged in to a given container registry wrapping the
podman login --get-logincommand with all its options.I've also added a few tests, which are possible without an actual log in. The GitHub Actions workflow as well as the playbook are adjusted copies of the
podman_volume_infoequivalent.I'd be willing to also look into creating
podman_loginandpodman_logoutmodules as listed in #93 and #94 since they'd be useful for a project of mine.Please let me know if you have any suggestions.
Labelling this PR for hacktoberfest would be appreciated.