Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change IpcMode default to shareable #444

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Conversation

rabi
Copy link
Contributor

@rabi rabi commented Jun 28, 2022

podman 4.1.x has changed the ipc namespace mode default to
shareable[1] that results in containers being restarted.

[1] containers/podman@3987c52

Resolves: rhbz#2101495

@sshnaidm
Copy link
Member

Please sign your commit: git commit -s, it's must in all repos in this org.
You can do git commit -s --amend and git push --force just to add the signature.

podman 4.1.x has changed the ipc namespace mode default to
shareable[1] that results in containers being restarted.

[1] containers/podman@3987c52

Resolves: rhbz#2101495
Signed-off-by: Rabi Mishra <ramishra@redhat.com>
@sshnaidm
Copy link
Member

Hmm, I see DCO job is still unhappy. Maybe to add a line before a signature?

@sshnaidm
Copy link
Member

The error:

Commit sha: 4208a4d, Author: rabi, Committer: rabi; Expected "rabi ramishra@redhat.com", but got "Rabi Mishra ramishra@redhat.com".

@sshnaidm
Copy link
Member

Nevermind, forced DCO it to pass.

@sshnaidm
Copy link
Member

check-github

@sshnaidm sshnaidm merged commit 6dc481a into containers:master Jun 29, 2022
@rabi
Copy link
Contributor Author

rabi commented Jun 29, 2022

Thanks Sagi, we would probably need a new release published to galaxy?

@sshnaidm
Copy link
Member

Yes, and also build RPM in Fedora, and then import into RDO. I and @JM1 will do.

@rabi
Copy link
Contributor Author

rabi commented Jun 29, 2022

ack, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants