Fix podman_tooling script

[cevich]

Depends on: #134

This script is needed by both podman and buildah CI. However a bug in
the line export GOPATH="${GOPATH:/var/tmp/go}" was causing it to
silently exit before doing it's job. Fortunately the downstream build
systems are somewhat tolerant, so the problem wasn't noticed at image
build time.

Simplify the script by requiring it to be called under $SUDO, this
allows moving a bunch of golang variable definitions into the script and
also making it set -e so failures are noticed sooner.

Ref: Silent failure example: https://cirrus-ci.com/task/6089758945312768?logs=main#L1905-L1906

[lsm5]

LGTM

[cevich]

force-push: rebased on @lsm5 #134 to make sure my podman_tooling.sh changes work.

[lsm5]

lilto command not found

[edsantiago]

All the sudo bash makes me cringe. Why not just add a hashbang-bash line to the script, make it 755, and invoke it directly? (This is a pet peeve of mine: let the script itself determine the interpreter it wants).

Also, CI is failing with a "kubik" error; sounds like the Ubuntu issue from a week or two ago.

[cevich]

All the sudo bash makes me cringe. Why not just add a hashbang-bash line to the script, make it 755, and invoke it directly?

I was afraid of making it appear like users should ever try and execute that script. I s'pose I could make it executable in the setup script.

Also, CI is failing with a "kubik" error; sounds like the Ubuntu issue from a week or two ago.

This is expected since this PR depends on #134

[cevich]

In fact, let's try it with #134 now and see if it builds successfully.

[cevich]

Force-push: Woopsie, forgot to do the chmod +x to the script.

[github-actions]

Cirrus CI build successful. Image ID c6193881921355776 ready for use.

[edsantiago]

6b66a74 LGTM (I did not review 0220c22)

[cevich]

Thanks @edsantiago

[cevich]

Status note: Waiting for #134 to merge, then this can go in.