Support no-clone build-push mode #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cevich
changed the title
cevich
added
no_skopeo_cidev
cevich
force-pushed
the
build_push_dot
branch
from
e53adac
to
4b9327b
Compare
|
@edsantiago FYI I bumped out a bunch of timebomb dates in this PR b/c I only need to make the fedora-based build_push VM (so it can be tested). Is this going to mess you up in #331 ? |
|
Can you please merge 331? It's done. |
|
Cirrus CI build successful. Found built image names and IDs:
|
|
Yep, np, done. BTW, unless you need aa second-look, please feel free to just merge those PRs yourself. No reason for unnecessary administratia here 😀 |
cevich
force-pushed
the
build_push_dot
branch
from
4b9327b
to
c0cda20
Compare
As originally conceived, the build context for each image lives in the
respective podman, buildah, and skopeo repositories. A future set of
PRs will move both the source and build automation into the
new containers/image_build repository. This is needed to support
images that are point-in-time rebuildable and run test-builds on
image context changes.
Add a magic 2nd argument prefix ('.'), and conditionals to prevent
cloning the build context repo. This will allow for an interim period
where build automation can run from both the current and new repository
until the context repos can be moved.
Signed-off-by: Chris Evich <cevich@redhat.com>
cevich
force-pushed
the
build_push_dot
branch
from
c0cda20
to
565d822
Compare
|
Cirrus CI build successful. Found built image names and IDs:
|
|
I was partway through review. No showstopper concerns.
The no-surprises factor: making sure everyone knows what's going on in this repo. Thanks for merging it. |
cevich
added a commit
to cevich/automation_images
that referenced
this pull request
Feb 29, 2024
Signed-off-by: Chris Evich <cevich@redhat.com>
Merged
cevich
added a commit
to cevich/automation_images
that referenced
this pull request
Feb 29, 2024
Signed-off-by: Chris Evich <cevich@redhat.com>
Well I appreciate that. Just don't want you to feel obligated, should the need arise in some more urgent situation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As originally conceived, the build context for each image lives in the respective podman, buildah, and skopeo repositories. A future set of PRs will move both the source and build automation into the new containers/image_build repository. This is needed to support images that are point-in-time rebuildable and run test-builds on image context changes.
Add a magic 2nd argument prefix ('.'), and conditionals to prevent cloning the build context repo. This will allow for an interim period where build automation can run from both the current and new repository until the context repos can be moved.