Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop installing python-is-python2 for CI #399

Merged
merged 1 commit into from
Jun 23, 2021
Merged

Conversation

smcv
Copy link
Collaborator

@smcv smcv commented Jan 1, 2021

Merging #344 made this unnecessary.

@smcv
Copy link
Collaborator Author

smcv commented Jun 10, 2021

It would be great if someone could merge this so I can run tests on branches on a modern system without always having to rebase them onto this one, and then rebase them back onto master for review :-)

@smcv smcv marked this pull request as draft June 10, 2021 18:31
@smcv
Copy link
Collaborator Author

smcv commented Jun 10, 2021

#344 had the important parts of this change, so I merged that instead.

Merging containers#344 made this unnecessary.

Signed-off-by: Simon McVittie <smcv@collabora.com>
@smcv smcv changed the title Use Python 3 for test/demo code Stop installing python-is-python2 for CI Jun 10, 2021
@smcv smcv marked this pull request as ready for review June 10, 2021 18:33
@smcv
Copy link
Collaborator Author

smcv commented Jun 10, 2021

OK, the only remaining change here after merging #344 is to stop installing the deprecated package that provides /usr/bin/python.

@smcv
Copy link
Collaborator Author

smcv commented Jun 23, 2021

This is trivial (just makes CI stricter) and CI still passes, so I'm going to merge it unreviewed. Please revert if you don't like it.

@smcv smcv merged commit 79e9a07 into containers:master Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant