Skip to content

Commit

Permalink
Change default for podman build to --pull missing
Browse files Browse the repository at this point in the history
This is causing the buildah build --help line to output a strange string

--pull string[="true"] Should be

--pull string[="missing"]

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
  • Loading branch information
rhatdan committed Jun 11, 2024
1 parent 44ef3a8 commit 75fc4f9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/cli/common.go
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ always: pull base and SBOM scanner images even if the named images are present
missing: pull base and SBOM scanner images if the named images are not present in store.
never: only use images present in store if available.
newer: only pull base and SBOM scanner images when newer images exist on the registry than those in the store.`)
fs.Lookup("pull").NoOptDefVal = "true" //allow `--pull ` to be set to `true` as expected.
fs.Lookup("pull").NoOptDefVal = "missing" //allow `--pull ` to be set to `missing` as expected.
fs.BoolVar(&flags.PullAlways, "pull-always", false, "pull the image even if the named image is present in store")
if err := fs.MarkHidden("pull-always"); err != nil {
panic(fmt.Sprintf("error marking the pull-always flag as hidden: %v", err))
Expand Down

0 comments on commit 75fc4f9

Please sign in to comment.